Conversation
11 tasks
adwk67
marked this pull request as ready for review
September 17, 2026 11:38
6 tasks
adwk67
marked this pull request as draft
September 17, 2026 13:40
20 tasks
adwk67
marked this pull request as ready for review
September 18, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #1645
N.B.
26.9.0not donepossible until Nexus limits allow uploads againas it brings a new dependency with it -libatomic- which would need to be added to the image. Nothing requries node 26 so have left this at version24.19.0.0.12.15not possible until action has been fixed:jq: error (at sbom.json:64): Cannot iterate over null (null)Possible fix:
Important
Previously the opa-auth-manager was tested against one hard-coded version of airflow and the FAB provider, set in pyproject.toml. This was true for both in-image testing and local testing. For the airflow 3 tree that pin had drifted off every version we actually ship, so the tests were passing against an API the images no longer used. Now the specific version of airflow is tracked in the image and the auth-manager is tested against THAT version, as well as components that are specified in the constraints list and elsewhere (such as python). This means we are actually testing what we bake into the image. The builder stage runs once per image, so this happens for EVERY supported version - 2.9.3, 3.0.6, 3.2.2 and 3.3.1 - each against its own airflow, FAB provider and python. Running the tests by hand is the exception: there is no constraints file involved there, so the versions have to be named explicitly. That is what the local dependency group is for, and it is pinned to the latest supported version.
OPA tests failed due to mismatch between FAB provider and the opa-auth-manager. Fixed as part of this PR:
Nightly tests tested with stackabletech/airflow-operator#865:
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.